Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(util) apply a fix to Test::Nginx as a patch #553

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

thibaultcha
Copy link
Member

The fix ensures that the --- shutdown_error_log check in the END block is skipped when no error.log was produced.

The fix ensures that the `--- shutdown_error_log` check in the END block
is skipped when no error.log was produced.
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37921%. Comparing base (223a346) to head (ab4d9ab).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #553   +/-   ##
=============================================
  Coverage   90.37921%   90.37921%           
=============================================
  Files             47          47           
  Lines          10311       10311           
=============================================
  Hits            9319        9319           
  Misses           992         992           

see 2 files with indirect coverage changes

Flag Coverage Δ
unit 90.13820% <ø> (-0.01105%) ⬇️
valgrind 81.21406% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thibaultcha thibaultcha merged commit 6622c43 into main Jun 14, 2024
31 checks passed
@thibaultcha thibaultcha deleted the tests/flaky-attach branch June 14, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant